-
Notifications
You must be signed in to change notification settings - Fork 35
Cache dependencies in Actions builds #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7aafd5c to
4174b2b
Compare
This caches all of the main ESP dependencies as well as the cross-compiler, dropping build times by over two minutes.
3db0a0c to
89edeca
Compare
| key: esp-idf-${{ env.ESP_IDF_VERSION }} | ||
| - name: Check out ESP IDF | ||
| if: steps.esp-idf-cache.outputs.cache-hit != 'true' | ||
| id: esp-idf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It doesn't look like esp-idf (or install-sdk) IDs are used in other checks? I'm still quite new to GitHub Actions, but it seems like these don't need to be included, since there are quite a few other steps that also don't have ids? Would it make sense to only include ids that are used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, thanks for reviewing! They're the vestigial remains of an earlier in-progress version that needed them.
We're actually likely not to merge this now, as @thinkl33t got an automated build container sorted so I'll switch the firmware build over as it'll have the same impact as caching, and allow for easily locally reproducible builds.
|
Can we close this PR now that @thinkl33t has done the build container? |
|
@ChrisDick don't we need to use the build container in the |
|
I'm not familiar with the workflow, so I don't know. I'll reopen so we don't miss it. |
|
I'm not familiar with this flow specifically, but looking at how the |
This caches all of the main ESP dependencies as well as the cross-compiler, dropping build times by almost three minutes.