add disablePayloadSigning option #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some S3 compatible storage such as R2 do not support the Streaming SigV4 implementation used by AWSSDK.S3 which can be bypassed by setting DisablePayloadSigning = true when pushing to S3
Owner
|
@alek-mcgarry this looks like a great change. Please also update the docs as part of this to add the new config property: https://github.com/emgarten/Sleet/blob/main/doc/client-settings.md#amazon-s3-specific-properties Feel free to include any extra guidance on R2 or just call it out that it works with this setting here if it makes sense: https://github.com/emgarten/Sleet/blob/main/doc/feed-type-s3.md#using-s3-compatible-storage I wasn't familiar with R2 before, it looks like a great option for hosting feeds. |
Owner
|
This change is part of Sleet 6.4.0: https://www.nuget.org/packages/Sleet/6.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some S3 compatible storage such as R2 do not support the Streaming SigV4 implementation used by AWSSDK.S3 which can be bypassed by setting DisablePayloadSigning = true when pushing to S3