Open
Conversation
Should have done this ages ago.
emichael
force-pushed
the
improvement/node-environment
branch
from
b693037 to
9603078
Compare
wilcoxjay
approved these changes
Mar 23, 2026
| public void send(Message message, Address from, Address to) { | ||
| // Clone on message send | ||
| Message m = Cloning.clone(message); | ||
| network.send(new MessageEnvelope(from, to, message)); |
Collaborator
There was a problem hiding this comment.
s/message/m/? Otherwise m is not used.
| } | ||
| }, | ||
| true); | ||
| new Settings(true)); |
Collaborator
There was a problem hiding this comment.
The true in new Settings(true) is hard to understand without context. (To be fair, the old code was just as bad.) Maybe a static factory method Settings.logExceptions() that returns a new Settings(true)?
| thrownException = t; | ||
| }, | ||
| false); | ||
| new Settings(false)); |
Collaborator
There was a problem hiding this comment.
Settings.noLogExceptions()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review blocked on #86 being merged.