build(deps): Replace winapi by windows-sys
#5038
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YgorSouza
reviewed
Aug 30, 2024
`winapi` has not been updated for four years. `windows-sys` seems to have a good maintainer. `winit` also uses `windows-sys`. The Windows API calls are not changed. It just uses a different bindings library.
caspermeijn
force-pushed
the
windows-rs
branch
from
13986b4 to
b5ee43b
Compare
emilk
approved these changes
Sep 16, 2024
emilk
added
eframe
1 task
emilk
pushed a commit
that referenced
this pull request
Aug 12, 2025
This the second take of <#5038>, adjusted for newer version of `windows-sys`, and with merge conflicts resolved. I added the original author to `Co-authored-by:`. * Closes <#7334> * Closes <#5038> * [x] I have followed the instructions in the PR template Tested on Windows 10: <img width="322" height="272" alt="image" src="https://github.com/user-attachments/assets/15ddf0bf-1f30-452f-8764-07ccfce2b00c" /> <img width="802" height="632" alt="image" src="https://github.com/user-attachments/assets/db6f4586-cfa5-4f7f-996c-06f7e2489df6" /> Action run result: https://github.com/sola-contrib/egui/actions/runs/16748810761 --------- Co-authored-by: Casper Meijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winapihas not been updated for four years.windows-sysseems to have a good maintainer.winitalso useswindows-sys.The Windows API calls are not changed. It just uses a different bindings library.
Alternative
I tried to remove the Windows API calls from this crate. As stated in a comment,
winitcan do some of the work, but I was unable to fixwinitenough to use that. My poor knowledge of Windows API doesn't help with that.