Skip to content

Fix: Selectable whether to key handling in IME #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Fix: Selectable whether to key handling in IME #5182

wants to merge 5 commits into from

Conversation

rustbasic
Copy link
Contributor

@rustbasic rustbasic commented Sep 28, 2024 •
edited
Loading

Fix: Selectable whether to key handling in IME

Fix Issues: Backspace & arrow keys are completely broken

How about the default value is false on Linux and true on other platforms?
it's target_os lint error.

impl Default for TextEditStyle {
    fn default() -> Self {
        Self {
            #[cfg(target_os = "linux")]
            ime_key_handling: false,
            #[cfg(not(target_os = "linux"))]
            ime_key_handling: true,
        }
    }
}

@github-actions GitHub Actions
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5182-patch131
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@emilk emilk mentioned this pull request Sep 30, 2024
Merged
3 tasks
@emilk emilk closed this in #5188 Sep 30, 2024
@emilk emilk closed this in 15d3d43 Sep 30, 2024
@rustbasic rustbasic mentioned this pull request Sep 30, 2024
Merged
1 task
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@emilk @hacknus
Fix backspace/arrow keys in TextEdit on Linux (emilk#5188)
9a69c2b 
* Closes emilk#5008
* Closes emilk#5182
* Bug introduced in emilk#4912

I suspect this will make IME no longer work on Linux, though I don't
know if it ever worked.
I rather have backspace/arrows working though.

Please help test this (I don't have Linux!)

# Tested on
* [x] Mac
* [ ] Linux Wayland
* [x] Linux X11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[regression] [eframe] Backspace and arrow keys don't work in TextEdit eframe Linux: Backspace & arrow keys are completely broken

1 participant

@rustbasic