Remove a few unwrap #5860
Open
Remove a few unwrap #5860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5860-minfix |
emilk
requested changes
Mar 30, 2025
| .unwrap() | ||
| .is_some() | ||
| { | ||
| if gl.get_extension("WEBGL_debug_renderer_info").ok().is_some() { |
There was a problem hiding this comment.
This is a changes in behavior! What you want is probably something like
Suggested change
| if gl.get_extension("WEBGL_debug_renderer_info").ok().is_some() { | |
| if gl.get_extension("WEBGL_debug_renderer_info").ok().is_some_and(|ext| ext.is_some()) { |
There was a problem hiding this comment.
Could just use is_ok_and. And should maybe log the error as well, since it would be printed with unwrap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim was to do more, but most would be
if let(Some(...-rewrites which I assume are not wanted.