Update font: github.com/jslegers/emoji-icon-font #5877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the current emoji-icon-font.ttf with the updated font from jslegers/emoji-icon-font#19 to address emilk#1284 A follow-up should revert emilk@a90379a
13 tasks
danielhjacobs
force-pushed
the
danielhjacobs-patch-1
branch
from
2588363 to
28c16db
Compare
|
Preview available at https://egui-pr-preview.github.io/pr/5877-danielhjacobs-patch-1 |
|
I updated the image tests. I guess the updated font has some slight differences made by fontforge when saving the update. |
emilk
approved these changes
Apr 6, 2025
|
It's a bit surprising that the image tests fail (except the font book, where the number of support characters increased; as expected). |
|
@lucasmerlin maybe you can take a look at this? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the current emoji-icon-font.ttf with the updated font from jslegers/emoji-icon-font#19 to address #1284. The second commit then removes the now unnecessary hack.