Skip to content

Fix links and text selection in horizontal_wrapped layout #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025
Merged

Fix links and text selection in horizontal_wrapped layout #6905

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad71476
Fix links and text selection in horizontal_wrapped layout
lucasmerlin Apr 30, 2025
e6f1fef
Fix `PlacedRow::rect`
lucasmerlin May 6, 2025
304dbe3
Revert "Fix `PlacedRow::rect`"
lucasmerlin May 6, 2025
8d73653
Add rect_without_leading_space and use that
lucasmerlin May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/egui/src/widgets/label.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,9 @@ impl Label {
let pos = pos2(ui.max_rect().left(), ui.cursor().top());
assert!(!galley.rows.is_empty(), "Galleys are never empty");
// collect a response from many rows:
let rect = galley.rows[0].rect().translate(pos.to_vec2());
let mut rect = galley.rows[0].rect().translate(pos.to_vec2());
// The rect ignores first_row_indentation, so we add it back:
rect.min.x += first_row_indentation;
let mut response = ui.allocate_rect(rect, sense);
for placed_row in galley.rows.iter().skip(1) {
let rect = placed_row.rect().translate(pos.to_vec2());
Expand Down
Loading