fix: Assertion in egui_extras::FileLoader::load #6995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…::forget_image is called while image is loading
|
Preview available at https://egui-pr-preview.github.io/pr/6995-patch6755 |
emilk
reviewed
May 6, 2025
| ctx.request_repaint(); | ||
| log::trace!("finished loading {uri:?}"); | ||
| } else { | ||
| log::trace!("cancelled loading {uri:?}"); |
There was a problem hiding this comment.
We should explain why we ignore the newly loaded image and cancel. I.e., that it can only happen because forget_image was called.
We should also document that forget_image cancels in-progress loads, if any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the
BytesLoaderimplementation forFileLoaderincrates/egui_extras/src/loaders/file_loader.rsto improve thread safety and handle unexpected states more gracefully.Changes to thread safety and state handling:
Updated the cache logic to check if the
uriexists in the cache before inserting the result. If theuriis not found, a log message is added to indicate the loading was canceled. This change prevents overwriting cache entries unexpectedly.Closes Assertion in egui_extras::FileLoader::load triggers when Context::forget_image is called while image is loading #6755
I have followed the instructions in the PR template