Skip to content

fix: avoid CentralPanel overflowing in a window #7042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: avoid CentralPanel overflowing in a window #7042

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbb994d
resize ui to avoid overflow
avalsch May 9, 2025
27965e6
use ui.scope_builder instead of ui.new_child
avalsch May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions crates/egui/src/containers/panel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,20 +1111,20 @@ impl CentralPanel {
) -> InnerResponse<R> {
let Self { frame } = self;

let panel_rect = ui.available_rect_before_wrap();
let mut panel_ui = ui.new_child(
ui.scope_builder(
UiBuilder::new()
.ui_stack_info(UiStackInfo::new(UiKind::CentralPanel))
.max_rect(panel_rect)
.layout(Layout::top_down(Align::Min)),
);
panel_ui.set_clip_rect(panel_rect); // If we overflow, don't do so visibly (#4475)

let frame = frame.unwrap_or_else(|| Frame::central_panel(ui.style()));
frame.show(&mut panel_ui, |ui| {
ui.expand_to_include_rect(ui.max_rect()); // Expand frame to include it all
add_contents(ui)
})
|ui| {
let frame = frame.unwrap_or_else(|| Frame::central_panel(ui.style()));

frame.show(ui, |ui| {
ui.expand_to_include_rect(ui.max_rect()); // Expand frame to include it all
add_contents(ui)
})
},
)
.inner
}

/// Show the panel at the top level.
Expand Down
Loading