Skip to content

Support for Back button Key on Android #7073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 15, 2025
Merged

Support for Back button Key on Android #7073

merged 8 commits into from
Jun 15, 2025

Conversation

ardocrat
Copy link
Contributor

@ardocrat ardocrat commented May 21, 2025 •
edited
Loading

When your press a Back button on Android (for example at native-activity), Winit translates this key as NamedKey::BrowserBack. Added convertion to Key::Escape at egui-winit module.

@github-actions GitHub Actions
Copy link

Preview available at https://egui-pr-preview.github.io/pr/7073-backbuttonandroid
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@ardocrat
Copy link
Contributor Author

I think Key::Escape is more reliable in case with NamedKey::BrowserBack or we can create new key like Key::Back, what do you think @emilk @lucasmerlin ?

@lucasmerlin
Copy link
Collaborator

Hmm, I think a new back key would be nicer. There are some cases where I'd expect pressing back and pressing escape to do different things. E.g. pressing escape should clear focus while pressing back should take you back to the previous page even if something is focused.

@lucasmerlin lucasmerlin added egui egui-winit porblems related to winit feature New feature or request labels Jun 2, 2025
@ardocrat
Copy link
Contributor Author

ardocrat commented Jun 5, 2025

Added Key::BrowserBack as last at Keys, cause there is no groups for multimedia/navigation keys to support full keyboard layout from winit.

emilk
emilk reviewed Jun 7, 2025
View reviewed changes
lucasmerlin
lucasmerlin approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@emilk emilk merged commit 742da95 into emilk:main Jun 15, 2025
26 checks passed
jb55 pushed a commit to damus-io/egui that referenced this pull request Jul 17, 2025
@ardocrat @jb55
Support for Back button Key on Android (emilk#7073)
041d4d1 
When your press a Back button on Android (for example at
`native-activity`), [Winit translates this
key](https://github.com/rust-windowing/winit/blob/47b938dbe78702d521c2c7a43b6f741a3bb8cb0b/src/platform_impl/android/keycodes.rs#L237C42-L237C53)
as `NamedKey::BrowserBack`. Added convertion to `Key::Escape` at
`egui-winit` module.

---------

Co-authored-by: Advocat <[email protected]>
jb55 pushed a commit to damus-io/egui that referenced this pull request Jul 19, 2025
@ardocrat @jb55
Support for Back button Key on Android (emilk#7073)
31d021c 
When your press a Back button on Android (for example at
`native-activity`), [Winit translates this
key](https://github.com/rust-windowing/winit/blob/47b938dbe78702d521c2c7a43b6f741a3bb8cb0b/src/platform_impl/android/keycodes.rs#L237C42-L237C53)
as `NamedKey::BrowserBack`. Added convertion to `Key::Escape` at
`egui-winit` module.

---------

Co-authored-by: Advocat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilk emilk emilk left review comments

@lucasmerlin lucasmerlin lucasmerlin approved these changes

Assignees

No one assigned

Labels

egui egui-winit porblems related to winit feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ardocrat @lucasmerlin @emilk