-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Include all parameters in the demo app's layout test window #7460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Preview available at https://egui-pr-preview.github.io/pr/7460-demo-layout |
The resize region needs to be limited or else it expands beyond the viewport boundaries when main justify is set. The button needs to be larger than default to see the how alignment affects the components' text.
3593d3a
to
779b736
Compare
The resize region needs to be limited or else it expands beyond the viewport boundaries when main justify is set. The button needs to be larger than default to see the how alignment affects the components' text.
Turns out the default timeout for github actions is 6 hours (!). This PR sets some reasonable default for all workflows, the ones invoking cargo in some way are limited to 60 minutes and the remaining ones to 10-15mins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! But we should add some note that explains that main_justify breaks when adding more than a single element and then only show a single widget when main_justify is enabled.
The warning disappears when main wrap is set, and when resize area is restricted unless main justify is set.
The label will appear as long as the user is within one step of triggering the infinite auto-resize.
layout.mp4 |
This change adds the

main_align
andmain_justify
options to the "Layout Test" demo window.Since all
Layout
fields are being used I replaced theLayoutSettings
struct, but it required uncommenting the serde cfg_attr derives. This was commented out in bf19eb2 (and the feature name subsequently kept up-to-date), but it's not clear to me why so I can revert that commit and just update the demo struct if necessary.The button's size was increased to demonstrate the text alignment, and the
Resize::max_size()
works around auto-resizing formain_justify
.