-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: Add Configurable Speed and Direction to Spinner Control #7532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KongJian520
wants to merge
13
commits into
emilk:main
Choose a base branch
from
KongJian520:kongjian520/feat-Spinner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview available at https://egui-pr-preview.github.io/pr/7532-kongjian520feat-Spinner |
lucasmerlin
reviewed
Sep 23, 2025
feat: Add Configurable Speed and Direction to Spinner Control
@lucasmerlin I'm ready, thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces two new properties for the
Spinner
control:speed
andclockwise
, allowing developers to customize the behavior of its rotation animation.Major Changes
speed: Option<f64>
andclockwise: Option<bool>
fields to theSpinner
structure.speed()
andclockwise()
methods to facilitate setting these new properties.ui
method of theWidget
implementation,unwrap_or
is used to set default values for these two properties to ensure they work correctly even when not explicitly set.paint_at
method signature to directly accept the processedspeed
andclockwise
parameters to simplify the drawing logic.Spinner::new().paint_at(ui, rect, 1.0, true);
()