Rework Window margins and set clip_rect_margin to zero
#7725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7725-emilkno-clip-rect-margin View snapshot changes at kitdiff |
lucasmerlin
reviewed
Nov 17, 2025
emilk
force-pushed
the
emilk/no-clip-rect-margin
branch
from
3e634f4 to
d17aa52
Compare
Owner
Author
|
Oops - the windows headers shrunk… a lot. Good with screenshot tests 😅 |
Owner
Author
|
Oh no… I need to do the resize-corner interaction on top of the scroll area, or they will fight with each-other |
emilk
force-pushed
the
emilk/no-clip-rect-margin
branch
from
d17aa52 to
9205500
Compare
Owner
Author
|
I also need to tweak |
emilk
force-pushed
the
emilk/no-clip-rect-margin
branch
5 times, most recently
from
4ba0fdf to
60a01c0
Compare
emilk
force-pushed
the
emilk/no-clip-rect-margin
branch
from
60a01c0 to
7477492
Compare
emilk
force-pushed
the
emilk/no-clip-rect-margin
branch
from
7477492 to
c9980b0
Compare
Mingun
reviewed
Dec 31, 2025
| /// Allow child widgets to be just on the border and still have a stroke with some thickness | ||
| /// Allow widgets to paint this much outside the scroll area rect. | ||
| /// | ||
| /// Legacy. Should not be used anymore. |
Contributor
There was a problem hiding this comment.
Probably you should say, what to use instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScrollArea::content_margin#7722clip_rect_margin#5605What
Sets
clip_rect_marginto zero, and moves the margin ofWindows withScrollAreas, so that the scroll bars are now on the very edge of the windows they are in.Required