feat: add logical position aliases (top-start, top-end, bottom-start, bottom-end)#753
Draft
mohamedyasser27 wants to merge 1 commit intoemilkowalski:mainfrom
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds logical position aliases that are RTL-aware, following the CSS Logical Properties convention (similar to
margin-inline-start,padding-inline-end, etc.).New positions
top-starttop-lefttop-righttop-endtop-righttop-leftbottom-startbottom-leftbottom-rightbottom-endbottom-rightbottom-leftHow it works
A
resolvePosition()helper maps the logical alias to its physical equivalentbased on the existing
dirprop before the position is applied. No CSS changeswere needed — the existing
data-x-position/data-y-positionattributesalready handle layout correctly.
Backward compatible
Existing
top-left,top-right,bottom-left,bottom-rightare completelyunchanged. These are additive aliases only.
Usage
Changes
src/types.ts— added 4 new values to thePositiontypesrc/index.tsx— addedresolvePosition()helper and applied it inToaster