feat: custom margin top scale for background#376
Open
bryantbrock wants to merge 1 commit intoemilkowalski:mainfrom
Open
feat: custom margin top scale for background#376bryantbrock wants to merge 1 commit intoemilkowalski:mainfrom
bryantbrock wants to merge 1 commit intoemilkowalski:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the emil Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
FYI I'm referencing this very commit in a production app, testing looks great. Don't take my word for it though. |
|
Hey! Any updates regarding this PR? I have the exact same issue as @bryantbrock using Vaul in a Capacitor app. If the idea is not to overcomplicate the API with more props, it is also feasible to change the direct use of env(safe-area-inset-top) to a CSS variable that defaults to it, so that it can at least be overridden with CSS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow moving the scaled background down some to look better in PWA or mobile apps (using capacitor).
Pass in a value to the root
backgroundMarginTop={75}and see the background page shift down.