Skip to content

feat: custom margin top scale for background#376

Open
bryantbrock wants to merge 1 commit intoemilkowalski:mainfrom
bryantbrock:background-custom-y-scale
Open

feat: custom margin top scale for background#376
bryantbrock wants to merge 1 commit intoemilkowalski:mainfrom
bryantbrock:background-custom-y-scale

Conversation

@bryantbrock
Copy link

Allow moving the scaled background down some to look better in PWA or mobile apps (using capacitor).

Pass in a value to the root backgroundMarginTop={75} and see the background page shift down.

Before After
simulator_screenshot_38BEF8FA-EF2D-4503-BF3C-AA71BF857442 simulator_screenshot_40E193C8-486B-4737-AA66-7C5723FBD8A1

@vercel
Copy link

vercel bot commented Jun 11, 2024

Someone is attempting to deploy a commit to the emil Team on Vercel.

A member of the Team first needs to authorize it.

@bryantbrock
Copy link
Author

FYI I'm referencing this very commit in a production app, testing looks great. Don't take my word for it though.

@RicardoDalcin
Copy link

Hey! Any updates regarding this PR?

I have the exact same issue as @bryantbrock using Vaul in a Capacitor app.

If the idea is not to overcomplicate the API with more props, it is also feasible to change the direct use of env(safe-area-inset-top) to a CSS variable that defaults to it, so that it can at least be overridden with CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants