fix: ensure modal={false} applies when using controlled open state#576
Open
y-solb wants to merge 1 commit intoemilkowalski:mainfrom
Open
fix: ensure modal={false} applies when using controlled open state#576y-solb wants to merge 1 commit intoemilkowalski:mainfrom
y-solb wants to merge 1 commit intoemilkowalski:mainfrom
Conversation
FabTrey
approved these changes
May 26, 2025
|
Having issues with this too. Anything stopping this from getting merged? |
Author
|
I ran into the same issue and had temporarily worked around it like this: Would love to see this merged! @NicHaley |
|
Thank you @y-solb this was my exact issue and your suggestion worked perfectly! If anyone else needs this I found the easiest way to fix it is with patch-package. Here is a good post about how to use it. |
|
Same here! |
For those using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes an issue where
modal={false}had no effect when using a controlledopenprop.Why
Internally, the
modalcheck only applied on initial mount. When controlling the drawer state using theopenprop, pointer events were not correctly restored on open.How
Added
isOpenas a dependency to theuseEffectthat appliespointer-events: autowhenmodalis false.Related
No open issue yet, but related to modal mode accessibility and pointer control.
Thanks for this great library! 😊