Skip to content

1.2-py3: fix Iconv in generated pkg-config file #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmercm merged 1 commit into from
Jul 11, 2026
Merged

1.2-py3: fix Iconv in generated pkg-config file #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions 1.2-py3/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ RUN apk --update add --no-cache boost-python3 boost
ninja "-j$(nproc)" && \
ninja install && \
cd .. && \
# Strip leaked CMake imported-target names from the generated pkg-config file
sed -i 's/ *-lIconv::Iconv//g' /usr/lib/pkgconfig/libtorrent-rasterbar.pc && \
# Remove temp files
cd && \
apk del --purge build-dependencies && \
Expand Down
2 changes: 2 additions & 0 deletions 1.2-py3/container-structure-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,5 @@ fileContentTests:
- name: "pkgconfig"
path: "/usr/lib/pkgconfig/libtorrent-rasterbar.pc"
expectedContents: ["Libs:.*-ltorrent-rasterbar"]
# No unresolved CMake imported-target names (e.g. -lIconv::Iconv) should leak into the Libs line
excludedContents: ["-l\\S*::"]