Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ export default eslintConfig.defineConfig([
},
sourceType: 'module',
globals: {
...globals.builtin,
...eslintPluginVitest.environments.env.globals,
},
},
Expand Down Expand Up @@ -217,24 +218,29 @@ export default eslintConfig.defineConfig([
},
],
// Style and clarity preference differences
'unicorn/import-style': 'off',
'unicorn/no-array-for-each': 'off',
'unicorn/consistent-class-member-order': 'off',
'unicorn/consistent-function-scoping': ['error', { checkArrowFunctions: false }],
'unicorn/import-style': 'off', // mostly overridden by noNodeSubpathImports.mjs
'unicorn/max-nested-calls': 'off',
'unicorn/no-array-reduce': 'off',
'unicorn/no-await-expression-member': 'off',
'unicorn/no-break-in-nested-loop': 'off', // unicorn/no-duplicate-loops + unicorn/prefer-continue encourage this
'unicorn/no-hex-escape': 'off',
'unicorn/no-unreadable-new-expression': 'off',
'unicorn/no-useless-undefined': 'off',
'unicorn/prefer-string-raw': 'off',
'unicorn/prefer-switch': 'off',
'unicorn/prefer-ternary': 'off',
'unicorn/prevent-abbreviations': 'off',
// Too many false positives 😡
'unicorn/consistent-function-scoping': ['error', { checkArrowFunctions: false }],
'unicorn/no-array-callback-reference': 'off',
'unicorn/no-array-method-this-argument': 'off',
'unicorn/prefer-https': 'off', // TODO(cemmer): turn back on when comments can be excluded
'unicorn/prefer-type-error': 'off',

// ***** eslint:recommended *****
'unicorn/prevent-abbreviations': 'off',
// Overly broad rules with too many false positives 😡
'unicorn/no-unsafe-string-replacement': 'off', // doesn't curly braces in regex search
'unicorn/prefer-await': 'off', // doesn't check if the call site is in an async context
'unicorn/prefer-https': 'off', // comments can't be excluded
'unicorn/prefer-iterator-to-array': 'off', // ArrayIterator#toArray() doesn't exist
'unicorn/prefer-minimal-ternary': 'off', // lots of false positives, hurts readability

// ***** ESLint:recommended *****
// Referencing ASCII characters <32 is entirely legitimate
'no-control-regex': 'off',
},
Expand Down Expand Up @@ -292,7 +298,7 @@ export default eslintConfig.defineConfig([
'@typescript-eslint/no-unused-vars': [
'error',
{
/*** @eslint/js defaults ***/
/*** @ESLint/js defaults ***/
vars: 'all',
caughtErrors: 'all',
reportUsedIgnorePattern: false,
Expand Down
34 changes: 24 additions & 10 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
"eslint-plugin-jsdoc": "63.0.6",
"eslint-plugin-prettier": "5.5.6",
"eslint-plugin-simple-import-sort": "13.0.0",
"eslint-plugin-unicorn": "65.0.1",
"eslint-plugin-unicorn": "66.0.0",
"globals": "17.6.0",
"prebuildify": "6.0.1",
"prettier": "3.8.4",
Expand Down
Loading
Loading