feat: implement deployment-style rollout for replicant sets#1184
Merged
feat: implement deployment-style rollout for replicant sets#1184
Conversation
This commit ensures that the very first node evacuation under rolling replicants update has non-empty list of migration targets, e.g. if `MaxUnavailable` is 1 and `MaxSurge` is 0, which means first "current" replicant undergoes scaling down when no "update" replicants are up yet.
* Scaling up sets RS replicas to desired count directly. * Scaling down processes `MaxUnavailable` replicants at a time with usual admission checking (evacuation gating, session drain, DS replication site) before scheduling pods for deletion: attaching `pod-deletion-cost` and decrementing RS replica count.
This change ensures that replicants that are already in the process of scaling down bypass unavailability budget checks, so that their deletion will eventually complete.
This commit makes all replicants eligible to serve "listeners" managed service, not only "update" set replicants, in line with gradual rolling update strategy for replicants.
keynslug
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main-3.x #1184 +/- ##
============================================
+ Coverage 74.17% 75.36% +1.18%
============================================
Files 48 48
Lines 3667 4006 +339
============================================
+ Hits 2720 3019 +299
- Misses 801 832 +31
- Partials 146 155 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zmstone
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reworks how Operator manages set of EMQX replicant nodes.
maxUnavailable/maxSurgeparameters.maxUnavailableparameter.Followup to #1179, includes minor related changes.
Important notes
However it should not have as dramatic effect as feat: switch core StatefulSet to in-place rolling updates #1179 does.