refactor(api): remove bootstrapAPIKeys from CR spec#1189
Merged
Conversation
This commit removes `bootstrapAPIKeys` from the spec, effectively removing ability to provision EMQX Dashboard API keys through bootstrap file. This mechanism is not fully compatible with K8s operational model that dictates that system state must eventually reflect specification: depending on EMQX version, changing this field either does not do anything or cause creating of new API keys on any change without retiring pre-existing ones. The plan is to replace this mechanism by a dedicated CRD in the future.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-3.x #1189 +/- ##
============================================
+ Coverage 76.03% 76.12% +0.09%
============================================
Files 48 48
Lines 3998 3967 -31
============================================
- Hits 3040 3020 -20
+ Misses 799 793 -6
+ Partials 159 154 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ieQu1
approved these changes
Apr 23, 2026
zmstone
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
bootstrapAPIKeysfrom the spec, effectively removing ability to provision EMQX Dashboard API keys through bootstrap file.This mechanism is not fully compatible with K8s operational model that dictates that system state must eventually reflect specification: depending on EMQX version, changing this field either does not do anything or cause creating of new API keys on any change without retiring pre-existing ones. The plan is to replace this mechanism by a dedicated CRD in the future.