fix: avoid field spillover in parsing DS API responses#1191
Merged
fix: avoid field spillover in parsing DS API responses#1191
Conversation
This commit fixes a bug in `GetDSReplicationStatus` that was causing `transitions` field context to spill over to next items in `DBs` array.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-3.x #1191 +/- ##
============================================
+ Coverage 77.33% 77.86% +0.53%
============================================
Files 48 48
Lines 3948 3917 -31
============================================
- Hits 3053 3050 -3
+ Misses 742 722 -20
+ Partials 153 145 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thalesmg
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in
GetDSReplicationStatusthat was causingtransitionsfield context to spill over to next items inDBsarray.Port of #1190's commit.