fix(handler): preserve request order for repeated query-string params - #138
Merged
Merged
Conversation
qzhuyan
approved these changes
Aug 5, 2026
thalesmg
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
minirest_handler:parse_qs/1folds overcowboy_req:parse_qs/1(which yields pairs in request order) withlists:foldlwhile prepending each repeated value, so multi-value query parameters reached handlers in reverse request order:/qs_params?array=foo&array=bararrived as[<<"bar">>, <<"foo">>].Fix
Fold with
lists:foldrinstead. The last occurrence is seen first (stored as the scalar), and each earlier occurrence prepends in front of it, yielding request order. Single-occurrence params are unchanged (still a bare scalar, not a list); valueless flags (?foo→true) are unchanged as well.Behavior change
This is an observable ordering change for any consumer of multi-value query params: they now arrive in request order instead of reversed. The reversed order was an undocumented fold accident, and no known consumer relies on it. Known consumers want request order — emqx/emqx#18267 promises "results in query-parameter order" for
GET /clients?clientid=a&clientid=b, and the order-sensitive tests in emqx/emqx#18268 tripped over the reversal. The existingt_qs_paramstest asserted the reversed order; it is flipped and strengthened to three occurrences.Follow-ups (not in this PR)
1.4.12).