-
Notifications
You must be signed in to change notification settings - Fork 3.5k
arm_neon.h: Enable additional native aliases #26068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Is there a test for this header that we can update ? |
|
@sbc100 @tlively There is a test case in #26042 (comment) that could be added, but I've never done that for this repo before so I might take me longer than either of you |
sbc100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but I'll leave the final review to @tlively since I'm not really familiar with this function of the test code.
|
@tlively @sbc100 Any advice about this error from the test I added? |
|
No idea I'm afraid. Maybe if you add |
1dfc420 to
6a5537c
Compare
8ea042b to
144856c
Compare
|
Maybe we could disable the auto-vectorizer for this change, along with a TODO linked to a new LLVM bug regarding |
A good plan, but I don't know how to do that; can you help? |
144856c to
a19fc5a
Compare
|
@sbc100 I fixed the test by turning off SIMDe level function inlining for this test only. For submitting the llvm optimization bug, the following command can be used as a reproducer:
Fails for
From our side, we run the entire SIMDe test suite (with complete coverage of the NEON intrinsics) using emscripten |
Fixes: #26042