Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jan 11, 2026

This ability was previously internally used when running autoconf but not otherwise available.

As a followup I plan to make this the default when the output filename as no extension at all.

Fixes: #25490, #26061

@sbc100 sbc100 requested review from juj and kripken January 11, 2026 17:11
@sbc100 sbc100 force-pushed the executable branch 3 times, most recently from e9cf1d2 to fc3791b Compare January 11, 2026 19:17
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comments

This ability was previously internally used when running autoconf but
not otherwise available.

As a followup I plan to make this the default when the output filename
as no extension at all.

Fixes: emscripten-core#25490, emscripten-core#26061
@sbc100 sbc100 merged commit 6e54001 into emscripten-core:main Jan 12, 2026
15 of 17 checks passed
@sbc100 sbc100 deleted the executable branch January 12, 2026 19:23
sbc100 added a commit to sbc100/emscripten that referenced this pull request Jan 12, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE.

The assumption here is that if we are generating a file with no
extension (or something called `a.out`) then we are trying to build
something that is directly runnable.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Jan 12, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE.

The assumption here is that if we are generating a file with no
extension (or something called `a.out`) then we are trying to build
something that is directly runnable.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Jan 12, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE.

The assumption here is that if we are generating a file with no
extension (or something called `a.out`) then we are trying to build
something that is directly runnable.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Jan 13, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE.

The assumption here is that if we are generating a file with no
extension (or something called `a.out`) then we are trying to build
something that is directly runnable.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Jan 13, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE.

The assumption here is that if we are generating a file with no
extension (or something called `a.out`) then we are trying to build
something that is directly runnable.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Jan 13, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE.

The assumption here is that if we are generating a file with no
extension (or something called `a.out`) then we are trying to build
something that is directly runnable.
sbc100 added a commit that referenced this pull request Jan 13, 2026
…26088)

Followup to #26085 which added initial support for `-sEXECUTABLE`.

The assumption here is that if we are generating a file with no
extension (or something called `a.out`) then we are trying to build
something that is directly runnable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How do I get emcc to make_js_executable when using CMake?

2 participants