-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add -sEXECUTABLE to add #! line to generated JS
#26085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+44
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9cf1d2 to
fc3791b
Compare
kripken
reviewed
Jan 12, 2026
Member
kripken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % comments
This ability was previously internally used when running autoconf but not otherwise available. As a followup I plan to make this the default when the output filename as no extension at all. Fixes: emscripten-core#25490, emscripten-core#26061
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 12, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE. The assumption here is that if we are generating a file with no extension (or something called `a.out`) then we are trying to build something that is directly runnable.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 12, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE. The assumption here is that if we are generating a file with no extension (or something called `a.out`) then we are trying to build something that is directly runnable.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 12, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE. The assumption here is that if we are generating a file with no extension (or something called `a.out`) then we are trying to build something that is directly runnable.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 13, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE. The assumption here is that if we are generating a file with no extension (or something called `a.out`) then we are trying to build something that is directly runnable.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 13, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE. The assumption here is that if we are generating a file with no extension (or something called `a.out`) then we are trying to build something that is directly runnable.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 13, 2026
Followup to emscripten-core#26085 which added initial support for -sEXECUTABLE. The assumption here is that if we are generating a file with no extension (or something called `a.out`) then we are trying to build something that is directly runnable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ability was previously internally used when running autoconf but not otherwise available.
As a followup I plan to make this the default when the output filename as no extension at all.
Fixes: #25490, #26061