Skip to content

Conversation

jmigual
Copy link
Contributor

@jmigual jmigual commented Apr 14, 2025

I've added the --no-lock flag and everything seemed to work.

Thins I've tested:

  • Opening an S3 repository
  • Browsing files from a backup of the repository
  • Downloading files.
  • Restoring a folder

All of this seemed to work fine.

Related issue #144

Copy link
Owner

@emuell emuell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that deserves a comment. Else this looks good to me.

Maybe something like:

// all expected restic operations are read-only right now, so always avoid locks
args.push(Cow::Borrowed(OsStr::new("--no-lock")));

?

@jmigual
Copy link
Contributor Author

jmigual commented Apr 14, 2025

Good point! I've updated it. Thanks for the fast response and for your amazing software! 😊

@emuell
Copy link
Owner

emuell commented Apr 14, 2025

Thanks for the contribution!

@emuell emuell merged commit 5c711dd into emuell:master Apr 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants