Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unaccent to SearchFilter #9385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgaligniana
Copy link
Contributor

@mgaligniana mgaligniana commented Apr 15, 2024

Description

Based on discussion #7759 I've created this PR to continue the work made in #8775 and #7733

There are no tests with PostgreSQL but I'm creating this to test with the CI

@mgaligniana mgaligniana force-pushed the add-unaccent-to-search-filter branch from 3a71f9b to f8825ba Compare April 15, 2024 14:10
@mgaligniana mgaligniana changed the title Add unaccent to SearchFilter (based on #7733) Add unaccent to SearchFilter Apr 15, 2024
@mgaligniana mgaligniana force-pushed the add-unaccent-to-search-filter branch from f8825ba to 2ff3f77 Compare April 15, 2024 14:15
@mgaligniana mgaligniana marked this pull request as draft April 15, 2024 14:20
@mgaligniana mgaligniana force-pushed the add-unaccent-to-search-filter branch from 2ff3f77 to a2bb1fb Compare April 15, 2024 18:55
@mgaligniana
Copy link
Contributor Author

mgaligniana commented Apr 15, 2024

Hi @auvipy!

In case I would like to add a postgres db creation step, to be able to add new tests: should I add a step here .github/workflows/main.yml?

@mgaligniana
Copy link
Contributor Author

mgaligniana commented May 27, 2024

I move this PR to Ready for review as the work is done but I need confirmation on how to add (or if it worth it) a step using PostgreSQL to be able to test it.

Thank you!

@mgaligniana mgaligniana marked this pull request as ready for review May 27, 2024 15:49
@jensjeflensje
Copy link

Tried this locally and the unaccent works great. It got me thinking though: anyone using unaccent is probably not interested in a full match either? The current code limits icontains from being used too alongside unaccent. I personally set my lookup prefix to "&": "unaccent__icontains" as that better fits my (and probably also other people's) usecases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants