-
Notifications
You must be signed in to change notification settings - Fork 3
Text is hyphenated and also wraps around line in posts #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@LunarFang416 Amazing, thanks for making quick work of this. I'm totally good with this functionality but for some reason the hyphen isn't displaying on long words -- am I doing something wrong: |
|
@JoelWiebe Thats very strange, I did the same and this is what i get: It doesn't add the text-wrap to the existing posts (posts before i implemented the feature), but it does it to all new posts. |
|
@LunarFang416 @JoelWiebe I think the context.measureText() method might be rounded or isn't completely accurate for some letters. Ex. the 's' and 'r' in the image. I'm pretty sure this is what's causing the inconsistency but I'm not sure what the fix would be. |
|
I'll look into this more, and see what I can do. Thanks for catching this! |
|
Another small thing to add is just to apply word wrap after editing a post, but otherwise LGTM! |
|
@LunarFang416 How is it that something that looks so simple very rarely is, haha. We can come back to this as it is a lower priority. I was having some trouble building this now though, I'm running npm install then ng serve but it cannot find a bunch of modules. Is this just something on my end? |
|
@LunarFang416 Is this ready to merge or what's the status on this? |
|
@Ammar-T i've been working on this for the past few weeks and couldn't make any progress; the same bugs are still happening. I just put it on hold now xd. |



Details
A few screenshots:
Closes #173