Skip to content

Conversation

@LunarFang416
Copy link
Contributor

Details

  • Text now doesn't cut off in the title and description and is hyphenated and moved over to the next line
  • I did a lot of testing to make sure it works properly, but I would appreciate if you could do some quick checks as well so that we know it works how we want it too

A few screenshots:

Screen Shot 2022-05-25 at 1 45 05 PM

Screen Shot 2022-05-25 at 1 45 33 PM

Closes #173

@JoelWiebe
Copy link
Contributor

@LunarFang416 Amazing, thanks for making quick work of this. I'm totally good with this functionality but for some reason the hyphen isn't displaying on long words -- am I doing something wrong:
Screen Shot 2022-05-26 at 1 33 14 AM

@LunarFang416
Copy link
Contributor Author

LunarFang416 commented May 26, 2022

@JoelWiebe Thats very strange, I did the same and this is what i get:
Screen Shot 2022-05-26 at 11 00 43 AM

It doesn't add the text-wrap to the existing posts (posts before i implemented the feature), but it does it to all new posts.

@LunarFang416 LunarFang416 added the Ready for review 👀 PR is complete and ready to be reviewed label May 26, 2022
@DCH25
Copy link
Contributor

DCH25 commented May 27, 2022

@LunarFang416 @JoelWiebe I think the context.measureText() method might be rounded or isn't completely accurate for some letters. Ex. the 's' and 'r' in the image. I'm pretty sure this is what's causing the inconsistency but I'm not sure what the fix would be.

image

@LunarFang416
Copy link
Contributor Author

I'll look into this more, and see what I can do. Thanks for catching this!

@DCH25
Copy link
Contributor

DCH25 commented May 27, 2022

Another small thing to add is just to apply word wrap after editing a post, but otherwise LGTM!

@LunarFang416 LunarFang416 added Work In Progress ⚒️ PR is not complete but open to feedback/discussion and removed Ready for review 👀 PR is complete and ready to be reviewed labels May 30, 2022
@JoelWiebe
Copy link
Contributor

@LunarFang416 How is it that something that looks so simple very rarely is, haha. We can come back to this as it is a lower priority.

I was having some trouble building this now though, I'm running npm install then ng serve but it cannot find a bunch of modules. Is this just something on my end?

@Ammar-T
Copy link
Contributor

Ammar-T commented Jun 11, 2022

@LunarFang416 Is this ready to merge or what's the status on this?

@LunarFang416
Copy link
Contributor Author

@Ammar-T i've been working on this for the past few weeks and couldn't make any progress; the same bugs are still happening. I just put it on hold now xd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Work In Progress ⚒️ PR is not complete but open to feedback/discussion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canvas text wraps mid-word

5 participants