Skip to content

feat: accept smtp_username and smtp_password as separate config fields#57

Merged
rubenhensen merged 1 commit intomainfrom
fix/issue-56-smtp-credentials-separate-fields
Mar 26, 2026
Merged

feat: accept smtp_username and smtp_password as separate config fields#57
rubenhensen merged 1 commit intomainfrom
fix/issue-56-smtp-credentials-separate-fields

Conversation

@rubenhensen
Copy link
Copy Markdown
Contributor

@rubenhensen rubenhensen commented Mar 26, 2026

Summary

  • Replaces smtp_credentials (array) with separate smtp_username and smtp_password config fields
  • Enables clean injection via ROCKET_SMTP_USERNAME and ROCKET_SMTP_PASSWORD env vars, each referencing a single Kubernetes secretKeyRef
  • Updates config structs, accessor methods, email sending logic, and example config files

Closes #56

Test plan

  • Verify SMTP sending works with smtp_username / smtp_password set in config
  • Verify SMTP sending works without credentials (unauthenticated)
  • Verify env var injection via ROCKET_SMTP_USERNAME / ROCKET_SMTP_PASSWORD

@rubenhensen rubenhensen merged commit 7ba5d17 into main Mar 26, 2026
4 checks passed
@rubenhensen rubenhensen deleted the fix/issue-56-smtp-credentials-separate-fields branch March 26, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept smtp_username and smtp_password as separate config fields

2 participants