fix: scope config.toml gitignore to repo root#71
Merged
rubenhensen merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
The unscoped `config.toml` pattern also matched `conf/config.toml`, which is a tracked file. This caused release-plz to fail with "uncommitted changes" because git sees a conflict between a tracked file and a gitignore rule. Prefixing with `/` restricts the pattern to the repository root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.tomlgitignore pattern matching the tracked fileconf/config.tomlconfig.tomlto/config.tomlso it only ignores the root-level runtime config, not the one inconf/Context
The pattern was added in #70 when flattening the crate structure. The unscoped pattern inadvertently matched
conf/config.toml, causing release-plz to error with: "the working directory of this project has uncommitted changes: conf/config.toml"Test plan