docs: add CODEOWNERS and issue/PR templates#112
Conversation
|
On it, @rubenhensen! I'm picking up PR #112 now and will review the repo governance scaffolding for correctness and rule-compliance. |
There was a problem hiding this comment.
Governance scaffolding looks solid — clean, minimal, and consistent with the repo. Verified: PR-template scripts (lint, check, test:unit/test:e2e, db:check) all exist; the template's "Conventional Commit" enforcement claim is accurate (repo has .github/workflows/pr-title.yml); the advisory URL matches SECURITY.md; both auto-applied labels (bug/enhancement) exist; YAML and frontmatter valid. Ran a per-rule check (security-issue routing, conventional-commit titles, AI-slop tells, docs/README standards, repo notes) — all compliant.
One non-blocking nit inline. Not blocking merge.
On the open question: defaulting CODEOWNERS to @rubenhensen is a reasonable start; moving to a team or path-split later is a one-liner as noted.
|
Reviewed! Everything looks good — all rule checks passed (security routing, commit titles, docs standards, repo notes, PR template). One non-blocking nit: has , which means users can still open blank issues and bypass the security advisory routing. Setting it to would enforce the template/advisory flow properly. Not a blocker for merge though. Full details in the PR comment. |
|
Thanks @dobby-coder — set |
|
Note: this PR had already merged by the time I applied the |
Closes #106.
Adds the repo-governance scaffolding: automatic reviewer routing plus consistent issue/PR structure.
What's added
.github/CODEOWNERS— global ownership so PRs auto-request a review..github/PULL_REQUEST_TEMPLATE.md— summary + linked issue + a checklist that reinforces existing gates (lint,check,test:unit/test:e2e,db:checkmigration safety) and reminds contributors of the Conventional-Commit title rule..github/ISSUE_TEMPLATE/—bug_report.md,feature_request.md, and aconfig.ymlwhose contact link routes security reports to the private advisory flow (so they don't get filed as public issues — pairs with Security: add SECURITY.md (responsible-disclosure policy) #102 / SECURITY.md).One thing to confirm
CODEOWNERS currently defaults everything to @rubenhensen (the dominant committer). If you'd rather route reviews to a team (e.g.
@encryption4all/<team>) or split ownership by path (e.g.drizzle/,.github/,src/lib/server/), say the word — it's a one-line change.