feat(nav): show logged-in state in marketing header#20
Merged
Conversation
When a session exists, the marketing nav hides the 'Log in' link and instead shows the user's email plus a 'My portal' link that points to /portal/dashboard for org users and /admin/organizations for admins. Closes #16
Contributor
Author
|
Dobby had started a parallel branch for #16 before spotting this one — closing mine, leaving the suggestions here in case they are useful to fold in while this is still draft:
Happy to send a follow-up PR on top of this once it lands, if any of the above are worth doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Marketing navigation now reflects the authenticated state of the visitor:
session.yiviAttributes[ATTR.email]) plus a "My portal" link. The link points to:/portal/dashboardforuserType === 'org'/admin/organizationsforuserType === 'admin'The logic is resolved server-side in the marketing layout load, so unauthenticated visits never receive session shape on the client.
Verification
npm run check— 0 errors, 0 warningsnpm run test:unit -- --run— 26 passednpm run build— green (with a dummyDATABASE_URLfor the adapter's analyse step)Interactive browser verification of the login/logout transition was not possible in this workspace (no seeded DB, no Yivi test environment).
Reviewer quickstart
Closes #16