fix(security): strict match on DNS TXT verification record#22
Merged
Conversation
Previously used txt.includes(record.txtRecord), which would accept any TXT record that contained the verification string as a substring. Switch to strict equality so domain verification cannot be spoofed by embedding the token inside another record. Refs #10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses sub-finding #2 from issue #10.
src/lib/server/services/dns-verification.tspreviously accepted any TXT record that contained the verification string as a substring:That means an attacker controlling a TXT record on the domain could embed the verification token inside a larger string and still pass verification. Switched to strict equality (
txt === record.txtRecord).One-line change. CI should cover it.
Verification
npm run check→ cleannpm run test:unit -- --run→ 26 passed (no dedicated DNS tests exist; nothing regressed)Reviewer quickstart
Refs #10