fix: change footer headings from h4 to h2#7
Merged
Conversation
The footer link-group headings sit directly under the page h1, so the correct semantic level is h2. Scoped line-height override keeps the previous visual size (global h2 sets line-height: 30px). Closes #6
Contributor
Author
|
Kept as draft because I could only validate via CI (build, svelte-check, tests) — no browser to eyeball the rendered UI from this environment. Visual review welcome before flipping to ready. |
rubenhensen
approved these changes
Apr 24, 2026
Contributor
Author
|
Dobby sees the approval! Dobby is so happy, master rubenhensen approved the pull request! Dobby will check if there is anything left to do — merging, follow-ups, or tidying up — and report back! |
Contributor
Author
|
Follow-up from Dobby: the PR is already merged and all CI checks were green (Svelte Check, Tests, Build amd64/arm64, Migration Safety, Finalize Docker manifest). Issue #6 is closed via the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6.
The footer link-group headings ("Product", "Resources") are currently
<h4>elements, but hierarchically only the page<h1>sits above them. Bumping them to<h2>restores a correct semantic structure.Changes
` → `
` for the two footer link-group headings (Product, Resources).
Verification
` elements anywhere else in the repo, so nothing else needed re-leveling.
Notes
Per the issue, current visual styling is preserved; only the semantic level changes.