fix: log DNS resolver errors and differentiate by code#90
Merged
Conversation
The catch block in verifyDns silently swallowed every error from resolve() and returned the same opaque message. Operators had no log line to grep when a customer reported repeated DNS check failures, and users could not distinguish a missing domain from a domain with no TXT records. Log the failed lookup with orgId, domain, error code, and message, and branch the user-facing message on ENOTFOUND / ENODATA. Falls back to the existing generic message for any other resolver error. Closes #88
rubenhensen
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catch {}inverifyDnswith a structuredconsole.errorlog (orgId, domain, error code, message) so operators can grep for failed lookups.NodeJS.ErrnoException.code:ENOTFOUND→ "Domain X not found",ENODATA→ "No TXT records found for X", everything else → existing generic message.tests/unit/dns-verification.test.tscovering happy path, mismatched TXT, ENOTFOUND, ENODATA, generic Error, and the "no record for org" early return.Closes #88
Test plan
npm run test:unit -- --run— 58 tests pass (6 new)npm run check— 0 errors, 0 warningsnpm run lint— clean