docs: fix C# keyword collision in README Quick Start#29
Merged
Conversation
'sealed' is a reserved C# keyword, so the README snippet fails to compile when pasted into a project. Closes #25
![dobby-coder[bot]](https://avatars.githubusercontent.com/in/3365457?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Verdict: LGTM — would approve if GitHub allowed self-approval.
Verified the fix:
sealedis indeed a C# reserved keyword —var sealed = ...would fail compilation with CS1041.- Both call sites (line 19 assignment and line 26
.UploadAsync()call) are renamed consistently toencrypted. - Grepped the rest of the repo for
\bsealed\b— remaining matches are doc-comments insideSealed.cs/SealPipeline.csreferring to "sealed bytes", not variable names. Nothing else to change. - PR title follows conventional-commit format.
Closes #25 cleanly. Safe to merge.
rubenhensen
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Quick Start snippet uses
sealedas a local variable name, which is a C# reserved keyword and fails to compile when pasted into a project. Renames the variable toencryptedin both the assignment and.UploadAsync()call site.Closes #25