docs: correct SDK prerequisite to .NET 10.0+ in README#35
Conversation
The README listed '.NET 8.0+ SDK' as a prerequisite, but both src/E4A.PostGuard.csproj and tests/E4A.PostGuard.Tests.csproj multi-target net8.0;net10.0. Building the solution requires an SDK that supports the highest target (net10.0); an 8.0 SDK cannot compile the net10.0 target. CI installs both 8.0.x and 10.0.x SDKs accordingly. Fixes #12 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![dobby-coder[bot]](https://avatars.githubusercontent.com/in/3365457?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rules Dobby 2 — rule-compliance pass. Verdict: changes requested (posted as COMMENT since GitHub blocks a formal REQUEST_CHANGES on our own PR). Review findings: 0; rule findings: 1.
The change is accurate and correctly verified. One binding-rule nit: the README now carries a 20-word parenthetical justifying why the net10.0 SDK is required. Per no-justification-paragraphs-for-simple-changes, a self-evident docs fix should just state the prerequisite (- .NET 10.0+ SDK) without narrating the reasoning in user-facing docs. Single inline comment below with a suggestion — please apply it.
Everything else checks out: conventional docs: title, docs-only so no tests needed, README structure intact, PR-body verification was explicitly requested by the issue.
| ### Prerequisites | ||
|
|
||
| - .NET 8.0+ SDK | ||
| - .NET 10.0+ SDK (the projects multi-target `net8.0` and `net10.0`, so the SDK must support the highest target, `net10.0`) |
There was a problem hiding this comment.
Rule check (no-justification-paragraphs-for-simple-changes): the parenthetical explaining why net10.0 is required is the kind of in-docs editorializing Ruben has asked us to drop for self-evident changes ("Just remove it and let that be that. No need to make a paragraph of text about it."). A reader of Prerequisites just needs the version, and issue #12 itself proposed the terse fix. Suggestion:
| - .NET 10.0+ SDK (the projects multi-target `net8.0` and `net10.0`, so the SDK must support the highest target, `net10.0`) | |
| - .NET 10.0+ SDK |
The multi-target detail already lives in the .csproj and git history.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ard-dotnet#35) The postguard-dotnet SDK and the pg-dotnet example both multi-target net8.0;net10.0, so a .NET 10 SDK is required to compile the highest target. Verified against E4A.PostGuard.csproj and the example's PostGuard.Example.csproj. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 participant
Summary
Closes #12.
The README's Prerequisites section listed
.NET 8.0+ SDK, but this understates what's actually required to build the SDK from source.Verification (against actual
.csprojfiles)Both project files multi-target
net8.0;net10.0:src/E4A.PostGuard.csprojnet8.0;net10.0tests/E4A.PostGuard.Tests/E4A.PostGuard.Tests.csprojnet8.0;net10.0Note: the issue body said the project targets
net10.0only — the current.csprojactually multi-targets, so the correct framing is that the SDK must support the highest target (net10.0). A .NET 8 SDK cannot compile thenet10.0target framework. This also matches CI, which installs both8.0.xand10.0.x(.github/workflows/build.yml,delivery.yml).Change
CHANGELOG.mdis auto-generated by release-please and was left untouched. No other docs reference the SDK version.Testing
dotnet build E4A.PostGuard.slnxwith only the .NET 10.0 SDK installed builds bothnet8.0andnet10.0targets successfully (0 warnings, 0 errors), confirming the .NET 10.0 SDK is what's needed and sufficient.🤖 Generated with Claude Code