fix(pg-node): drop no-op --send flag from npm script#55
Merged
Conversation
index.mjs only inspects --upload-only; --send was silently ignored and worked by coincidence (anything not --upload-only falls through to send-email). Keep the flag set minimal. Closes #52
Contributor
Author
|
Self-correcting pipeline pass — applied three rule fixes to this PR:
No code changes. |
Contributor
Author
There was a problem hiding this comment.
LGTM (cannot self-approve — same bot identity is the author).
Matches issue #52's preferred Option 1 exactly. index.mjs:28 only inspects --upload-only, so dropping --send is a true no-op: npm run send falls through to the default send-email branch with or without the flag. Verified no other references to --send in the repo. CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the no-op
--sendarg frompg-node'ssendscript.index.mjs:28only inspects--upload-only;--sendwas silently ignored.Closes #52.