Skip to content

fix(pg-node): drop no-op --send flag from npm script#55

Merged
rubenhensen merged 1 commit into
mainfrom
fix/pg-node-drop-send-flag
May 29, 2026
Merged

fix(pg-node): drop no-op --send flag from npm script#55
rubenhensen merged 1 commit into
mainfrom
fix/pg-node-drop-send-flag

Conversation

@dobby-coder

@dobby-coder dobby-coder Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Drops the no-op --send arg from pg-node's send script. index.mjs:28 only inspects --upload-only; --send was silently ignored.

Closes #52.

index.mjs only inspects --upload-only; --send was silently ignored
and worked by coincidence (anything not --upload-only falls through
to send-email). Keep the flag set minimal.

Closes #52
@dobby-coder dobby-coder Bot marked this pull request as ready for review May 28, 2026 23:41
@dobby-coder dobby-coder Bot requested a review from rubenhensen May 28, 2026 23:41
@dobby-coder

dobby-coder Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Self-correcting pipeline pass — applied three rule fixes to this PR:

  • Body trimmed — the prior body had multi-paragraph rationale for a one-line no-op flag removal. Per no-justification-paragraphs-for-simple-changes, small self-evident deletions ship without a "why this is gone now" section. Body is now a two-line summary + closing keyword.
  • Marked ready-for-review — per default-prs-to-ready, draft is reserved for low-confidence changes. CI is green and the script behaviour is unchanged (the flag was already ignored), so draft was unwarranted.
  • Reviewer assigned — per pr-review-assignments, every PR must request a reviewer; defaulted to @rubenhensen for this autonomous run.

No code changes.

@dobby-coder dobby-coder Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (cannot self-approve — same bot identity is the author).

Matches issue #52's preferred Option 1 exactly. index.mjs:28 only inspects --upload-only, so dropping --send is a true no-op: npm run send falls through to the default send-email branch with or without the flag. Verified no other references to --send in the repo. CI is green.

@rubenhensen rubenhensen merged commit de7bfcf into main May 29, 2026
2 checks passed
@rubenhensen rubenhensen deleted the fix/pg-node-drop-send-flag branch May 29, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pg-node: npm run send passes a --send flag that index.mjs silently ignores

1 participant