fix(pg-manual): point PKG_URL at modern staging endpoint#59
Conversation
Replace the legacy Radboud iHub PKG host (https://main.postguard.ihub.ru.nl/pkg) with the modern staging endpoint (https://pkg.staging.postguard.eu) so pg-manual matches pg-sveltekit, pg-node, and pg-dotnet, which all default to pkg.staging.postguard.eu. The /pkg path suffix is dropped because the staging host serves the PKG v2 API at the root. Closes #54 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Verdict: APPROVE / sign-off. Posted as a COMMENT review only because GitHub blocks a bot from approving its own PR (
dobby-coder[bot]authored and reviewed this PR) — treat this as a clean approval, not a withheld one. The requested human review from @rubenhensen is what gates merge.
Rules + review gate passed.
Change: pg-manual/examples/utils.js PKG_URL moves off the legacy iHub deployment (https://main.postguard.ihub.ru.nl/pkg) to the modern staging endpoint (https://pkg.staging.postguard.eu), aligning pg-manual with pg-sveltekit, pg-node, and pg-dotnet. Dropping the /pkg suffix is correct: the staging host serves the PKG v2 API at the root.
Review findings: none (Review Dobby 2: 0 findings).
Rule check: clean — every rule file in the memory repo was checked via parallel Haiku sub-agents; no genuine code violations. The repo notes flagged this exact legacy-iHub reference as the open issue this PR closes.
Verification: webpack build compiles clean (zero warnings); GET /v2/parameters and GET /v2/sign/parameters on the staging host both return 200. No test suite exists (example/reference app), so live-endpoint + build verification stands in for unit tests.
Gatekeeper housekeeping applied on sign-off: assigned @rubenhensen as reviewer (PR had none), and flipping the draft to ready-for-review — postguard-examples has no build/test CI (only pr-title.yml), so the draft cannot auto-promote.
Summary
pg-manual/examples/utils.jshardcoded the legacy Radboud iHub PKG deployment:This was the only file in the repo still pointing at the iHub host. The other three sub-projects all default to the modern staging endpoint:
pg-sveltekit/src/lib/config.ts:4—https://pkg.staging.postguard.eupg-node/src/config.mjs:4—https://pkg.staging.postguard.eupg-dotnet/Program.cs:10—https://pkg.staging.postguard.euThis PR aligns pg-manual with them.
Change
The
/pkgpath suffix is dropped: the iHub deployment served the PKG under/pkg, whereas the staging host serves the PKG v2 API at the root (matching the sibling configs). All other PKG references in pg-manual (utils.js,string.js,file.js) derive from this singlePKG_URLconstant, so the one-line change covers them all.Verification
npm install && npm run build— clean webpack compile, zero "export … was not found" warnings.GET https://pkg.staging.postguard.eu/v2/parameters→200GET https://pkg.staging.postguard.eu/v2/sign/parameters→200(the encryption + signing parameter fetches the examples perform both resolve against the new host)
Closes #54