Skip to content

fix(pg-manual): point PKG_URL at modern staging endpoint#59

Merged
rubenhensen merged 1 commit into
mainfrom
fix/pg-manual-pkg-staging-endpoint
Jun 19, 2026
Merged

fix(pg-manual): point PKG_URL at modern staging endpoint#59
rubenhensen merged 1 commit into
mainfrom
fix/pg-manual-pkg-staging-endpoint

Conversation

@dobby-coder

@dobby-coder dobby-coder Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

pg-manual/examples/utils.js hardcoded the legacy Radboud iHub PKG deployment:

export const PKG_URL = 'https://main.postguard.ihub.ru.nl/pkg'

This was the only file in the repo still pointing at the iHub host. The other three sub-projects all default to the modern staging endpoint:

  • pg-sveltekit/src/lib/config.ts:4https://pkg.staging.postguard.eu
  • pg-node/src/config.mjs:4https://pkg.staging.postguard.eu
  • pg-dotnet/Program.cs:10https://pkg.staging.postguard.eu

This PR aligns pg-manual with them.

Change

-export const PKG_URL = 'https://main.postguard.ihub.ru.nl/pkg'
+export const PKG_URL = 'https://pkg.staging.postguard.eu'

The /pkg path suffix is dropped: the iHub deployment served the PKG under /pkg, whereas the staging host serves the PKG v2 API at the root (matching the sibling configs). All other PKG references in pg-manual (utils.js, string.js, file.js) derive from this single PKG_URL constant, so the one-line change covers them all.

Verification

  • npm install && npm run build — clean webpack compile, zero "export … was not found" warnings.

  • GET https://pkg.staging.postguard.eu/v2/parameters200

  • GET https://pkg.staging.postguard.eu/v2/sign/parameters200

    (the encryption + signing parameter fetches the examples perform both resolve against the new host)

Closes #54

Replace the legacy Radboud iHub PKG host
(https://main.postguard.ihub.ru.nl/pkg) with the modern staging
endpoint (https://pkg.staging.postguard.eu) so pg-manual matches
pg-sveltekit, pg-node, and pg-dotnet, which all default to
pkg.staging.postguard.eu. The /pkg path suffix is dropped because the
staging host serves the PKG v2 API at the root.

Closes #54

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dobby-coder dobby-coder Bot requested a review from rubenhensen June 18, 2026 23:11

@dobby-coder dobby-coder Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE / sign-off. Posted as a COMMENT review only because GitHub blocks a bot from approving its own PR (dobby-coder[bot] authored and reviewed this PR) — treat this as a clean approval, not a withheld one. The requested human review from @rubenhensen is what gates merge.

Rules + review gate passed.

Change: pg-manual/examples/utils.js PKG_URL moves off the legacy iHub deployment (https://main.postguard.ihub.ru.nl/pkg) to the modern staging endpoint (https://pkg.staging.postguard.eu), aligning pg-manual with pg-sveltekit, pg-node, and pg-dotnet. Dropping the /pkg suffix is correct: the staging host serves the PKG v2 API at the root.

Review findings: none (Review Dobby 2: 0 findings).
Rule check: clean — every rule file in the memory repo was checked via parallel Haiku sub-agents; no genuine code violations. The repo notes flagged this exact legacy-iHub reference as the open issue this PR closes.
Verification: webpack build compiles clean (zero warnings); GET /v2/parameters and GET /v2/sign/parameters on the staging host both return 200. No test suite exists (example/reference app), so live-endpoint + build verification stands in for unit tests.

Gatekeeper housekeeping applied on sign-off: assigned @rubenhensen as reviewer (PR had none), and flipping the draft to ready-for-review — postguard-examples has no build/test CI (only pr-title.yml), so the draft cannot auto-promote.

@dobby-coder dobby-coder Bot marked this pull request as ready for review June 18, 2026 23:13
@rubenhensen rubenhensen merged commit 8b32a68 into main Jun 19, 2026
1 check passed
@rubenhensen rubenhensen deleted the fix/pg-manual-pkg-staging-endpoint branch June 19, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pg-manual: PKG_URL still points at legacy iHub deployment (main.postguard.ihub.ru.nl) — intentional?

1 participant