fix: add cancel button during file upload#188
Closed
dobby-coder[bot] wants to merge 1 commit into
Closed
Conversation
Closes #182. The encryption/upload progress UI rendered by SendButton exposed only a spinner and progress bar; users had no in-app way to abort a long upload. Adds a Cancel button to the upload-info-box that calls AbortController.abort() on the existing encryption/upload signal, flips selfAborted so the catch path resets to FileSelection, and provisions a fresh AbortController for the next attempt.
This was referenced May 9, 2026
Contributor
Author
|
Superseded by #202 (consolidation per encryption4all/dobby#53). Closing to keep the queue tidy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182.
Summary
SendButton.sveltepreviously rendered only a spinner and progress bar duringEncryptionState.Encrypting, leaving users no in-app way to abort an in-flight upload.AbortController.abort()on the existing signal already wired intopg.encrypt({ ..., signal }).selfAborted = truebefore aborting so the existing catch path instartEncryption()resets state toFileSelection(instead of routing to the generic Error panel).AbortControllerwith a fresh one so a subsequent send attempt is also cancellable.filesharing.canceli18n key (already used byEncryptionProgress.svelte) — no translations need updating.Test plan
Reviewer quickstart
`git fetch origin && git checkout fix/issue-182-cancel-on-upload && npm ci --legacy-peer-deps && npm run dev`
🤖 Generated with Claude Code