fix: open Yivi app on mobile /decrypt page instead of QR#201
Closed
dobby-coder[bot] wants to merge 1 commit into
Closed
fix: open Yivi app on mobile /decrypt page instead of QR#201dobby-coder[bot] wants to merge 1 commit into
dobby-coder[bot] wants to merge 1 commit into
Conversation
The /decrypt fallback page rendered a QR code on mobile, which is useless when the user is already on their phone. Mirror the /download page's pattern: detect mobile and pass mode=deeplink to YiviQRCode so it auto-clicks the Yivi-app button and triggers the universal link. Closes #163
This was referenced May 9, 2026
Contributor
Author
|
Superseded by #203 (consolidation per encryption4all/dobby#53). Closing to keep the queue tidy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On mobile, visiting the
/decryptfallback page (e.g. via the link in a PostGuard email) showed a QR code, which is useless when the user is already holding the phone they would scan with. Mirrors the existing/downloadpage pattern by detecting mobile and switching the underlyingYiviQRCodecomponent intodeeplinkmode, which auto-clicks the Yivi-app button and triggers the universal link to open the Yivi app directly.src/lib/components/fallback/Decrypt.svelte: importisMobilefrom$lib/browser-detect, computeisMobileDeviceonce at component init, and passmode={isMobileDevice ? 'deeplink' : 'qr'}toYiviQRCode.No locale or component-API changes; uses the existing
deeplinkmode already supported byYiviQRCode.svelteand used by/download.Conflict awareness
PR #198 (issue #162) also touches
src/lib/components/fallback/Decrypt.sveltebut only edits the<h3>text and adds a<p class="card-subtitle">inside the QR card. This PR only edits the<YiviQRCode ... />line and the imports/state at the top — non-overlapping line ranges, so it should rebase cleanly whichever lands first.Test plan
npm run check(svelte-check) — 0 errors / 0 warningsnpm run build— clean static buildnpx prettier --checkon touched file — formatted/decryptpage on a mobile device; the Yivi app should open via universal link instead of rendering a QR code/decryptpage on desktop; QR code should still render as beforeReviewer quickstart:
Closes #163