feat(decrypt-progress): show progress bar inside decrypt card with brand blue#243
Merged
Conversation
Contributor
|
Dobby has received the request! Routing to the right specialist now... |
…and blue Wrap the Decrypting state in the same decrypt-card box used during the Yivi/Ready step so the bar appears on the same page rather than a bare swap-out. Recolor the bar fill to --pg-primary-contrast for a darker brand blue that reads as a deliberate progress indicator.
rubenhensen
force-pushed
the
feat/decrypt-progress-bar
branch
from
906857e to
87a7fd0
Compare
![dobby-coder[bot]](https://avatars.githubusercontent.com/in/3365457?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code review
LGTM. Minor symmetry note: src/lib/components/fallback/Decrypt.svelte:256 still renders a bare <DecryptionProgress /> during STATES.Decrypting — if the goal is the boxed-card look across both decrypt flows, the fallback path would need the same .decrypt-card wrapper. Non-blocking; the fallback uses a different surrounding layout so this may be intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decrypt-cardbox used during the Yivi/Ready step so the bar appears in-place rather than swapping to a bare layout.--pg-primary-contrast(darker brand blue) for both determinate and indeterminate states.Test plan