chore: bump @e4a/pg-js to ^2.0.1#245
Merged
Merged
Conversation
Picks up the upload-validator removal from encryption4all/postguard-js#87 (released as 2.0.1 via the follow-up fix: commit in #88), which unblocks the staging email-preview modal flow — passing `onUploadInit` no longer throws `TypeError: unknown option "onUploadInit"`.
Contributor
|
Dobby has received the request! Routing to the right specialist now... |
![dobby-coder[bot]](https://avatars.githubusercontent.com/in/3365457?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code review
Patch bump @e4a/pg-js 2.0.0 → 2.0.1 drops the upload-option runtime validator whose allowlist had drifted from the type, unblocking the onUploadInit call added in #244. package.json and package-lock.json updated consistently; the resolved 2.0.1 exposes onUploadInit in both types and runtime.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up pg-js 2.0.1, which ships the removal of the upload-option runtime validator (encryption4all/postguard-js#87, re-tagged as a `fix:` in #88 to trigger the patch release).
The staging email-preview modal merged in #244 calls `sealed.upload({ onUploadInit: fn })` to capture the uuid as soon as the server allocates it. On 2.0.0 that threw `TypeError: sealed.upload(opts): unknown option "onUploadInit"` because the validator's allowlist had drifted from the type. On 2.0.1 the validator is gone, so the call works.
Test plan