Skip to content

fix(dev): mount build.rs into cryptify-fileshare so PG_CORE_VERSION compiles #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubenhensen wants to merge 1 commit into from
Closed

fix(dev): mount build.rs into cryptify-fileshare so PG_CORE_VERSION compiles #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ services:
- ./cryptify/conf/config.dev.toml:/app/config.toml:ro
- ./cryptify/src:/app/src
- ./cryptify/templates:/app/templates
- ./cryptify/build.rs:/app/build.rs:ro

@dobby-coder dobby-coder Bot Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Code review] PR branch's cryptify submodule pointer is 4c30e53, which predates the addition of build.rs upstream (cryptify#170, present from 7816df8). A fresh gh pr checkout 248 && git submodule update --init leaves ./cryptify/build.rs missing, so the bind mount has no source file and Docker will create an empty path or refuse to start — the stated test plan can't be executed against the branch as-shipped. Bump the submodule pointer or rebase onto main (already at 63066a1).

- ./cryptify/Cargo.toml:/app/Cargo.toml:ro

@dobby-coder dobby-coder Bot Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Rule: no-justification-paragraphs-for-simple-changes] After rebasing onto main (which already has the build.rs and Cargo.lock mounts), this PR collapses to a single added line. The three-bullet rationale in the PR body is more explanation than the change warrants — trim to one or two bullets and let the diff speak.

- ./cryptify/Cargo.lock:/app/Cargo.lock:ro

@dobby-coder dobby-coder Bot Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Code review] build.rs (line 21) and Cargo.lock (line 23) mounts duplicate work already on main via #246 (d52ee5b, 2026-06-03, which also bumped cryptify to 63066a1). Only the Cargo.toml mount on line 22 is genuinely new. Rebase onto main and drop these two lines.

- cryptify-target:/app/target
environment:
- RUST_LOG=info
Expand Down