fix(decrypt): await postal-mime import in parseMail to avoid race#256
Merged
Conversation
The previous fire-and-forget dynamic import left `PostalMime` undefined until the network round-trip resolved. Callers that hit parseMail before that (e.g. a hard-reload onto `/decrypt#<envelope>` on a slow connection) threw `Cannot read properties of undefined (reading 'default')`, which the surrounding catch swallowed into a generic "decryption failed" — even though decryption itself had succeeded. Replace with a memoized import promise that parseMail awaits at every call. All call sites already used await/.then so this is a no-op for them. Closes #253
Contributor
Author
|
Trimmed the PR description to drop the narrating prose and unchecked test-plan checkboxes (rule: Not adding a regression test (rule: |
rubenhensen
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
Summary
src/lib/components/fallback/email.js: memoize thepostal-mimedynamic import andawaitit inparseMail.Verification
npm run check— 0 errors, 0 warningsnpm run build— succeedsnpm run lint— pass