chore: remove stale Playwright smoke test#261
Merged
Conversation
The default SvelteKit template smoke test in tests/test.ts asserted an h1 of "Welcome to SvelteKit", which the marketing landing page has not rendered for a long time. npm test is not wired into CI, so the failing assertion was invisible and the single-test suite gave a false impression of coverage. Remove tests/test.ts and the unused "test" npm script. Real Playwright coverage is tracked separately in #44; playwright.config.ts and the @playwright/test dependency are kept as scaffolding for that work. Closes #217 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rubenhensen
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes
tests/test.ts— the default SvelteKit template smoke test — and the unusedtestnpm script (option 2 from #217).The test asserted an
h1of"Welcome to SvelteKit", which the marketing landing page (src/routes/(marketing)/+page.svelte) has not rendered for a long time. Becausenpm testis not wired into CI (onlysvelte-checkandlintrun), the broken assertion was invisible, and the single-test suite gave a false impression of test coverage.Changes
tests/test.ts(the stale stub)."test": "playwright test"script frompackage.json.Kept on purpose
playwright.config.tsand the@playwright/testdevDependency are retained as scaffolding, since real Playwright/integration coverage is tracked separately in Integration tests #44.Verification
npm run lint(prettier --check .+eslint .) — passesnpm run check(svelte-check) — 0 errors, 0 warningsCloses #217. Related: #44.