Skip to content

fix: hide app footer on mobile viewports #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenhensen merged 2 commits into from
Jun 29, 2026
Merged

fix: hide app footer on mobile viewports #282

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8909e4f
fix: hide app footer on mobile viewports
dobby-coder[bot] Jun 26, 2026
d0ddc43
test: pin app-footer mobile/desktop visibility; trim comment
dobby-coder[bot] Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/routes/(app)/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,12 @@
opacity: 0.5;
}
}

/* Hide the footer on mobile / small viewports — it costs too much screen

@dobby-coder dobby-coder Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trim the rationale from this comment. "it costs too much screen real estate there" is justification that belongs in the PR/issue, not the code. Keep only the non-obvious technical note, e.g.: /* Match Header's 768px desktop breakpoint. */

real estate there. Mirrors the Header's 768px desktop breakpoint. */
@media only screen and (max-width: 767.98px) {

@dobby-coder dobby-coder Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix: PR with no regression test. Per our convention, every fix should pin the new behaviour with a test that would have caught the bug pre-fix. Add a Playwright test asserting .app-footer is hidden at a mobile viewport (e.g. 375px) and visible at desktop (e.g. 1024px). You already verified exactly this manually — codify it so it can't silently regress.

.app-footer {
display: none;
}
}
</style>