Skip to content

fix: dropzone focus state and add-more-files button semantics #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenhensen merged 4 commits into from
Apr 3, 2026
Merged

fix: dropzone focus state and add-more-files button semantics #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f9fe24
fix: add focus state to dropzone remove button and make add-more-file…
rubenhensen Mar 5, 2026
2ba62ae
fix: remove hardcoded container names to allow multiple worktrees to …
rubenhensen Mar 6, 2026
f030c93
Merge branch 'main' into fix/issue-23
rubenhensen Apr 3, 2026
f1d2a7b
fix: prevent focus outlines from being clipped or hidden
rubenhensen Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/components/HelpToggle.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
width: 100%;
box-sizing: border-box;
min-width: 0;
overflow: hidden;
overflow: clip;
overflow-clip-margin: 4px;
}

.help-section.bordered {
Expand All @@ -56,6 +57,8 @@
outline: 2px solid var(--pg-primary);
outline-offset: 2px;
border-radius: var(--pg-border-radius-sm);
position: relative;
z-index: 1;
}

.help-section.bordered .help-toggle {
Expand Down
13 changes: 12 additions & 1 deletion src/lib/components/filesharing/inputs/FileInput.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@
icon="+"
size="lg"
variant="default"
onclick={() => {}}
/>
</div>
{/if}
Expand Down Expand Up @@ -343,7 +344,10 @@
gap: 0.5rem;
max-height: 300px;
overflow-y: auto;
overflow-x: clip;
overflow-clip-margin: 4px;
pointer-events: auto;
padding-right: 4px;
}

.dz-previews.encrypting :global(.remove-button) {
Expand All @@ -356,6 +360,7 @@
margin: 0;
min-height: 0;
position: relative;
background: transparent;
}

/* Preview template styles (injected by Dropzone, so must be :global) */
Expand Down Expand Up @@ -416,7 +421,7 @@
.dz-previews :global(.remove-button) {
cursor: pointer;
height: 100%;
padding: 4px 0 4px 4px;
padding: 4px 4px 4px 4px;
border-radius: var(--pg-border-radius-md);
transition: all 0.2s ease;
display: flex;
Expand All @@ -429,6 +434,12 @@
background-color: var(--pg-soft-background);
}

.dz-previews :global(.remove-button:focus-visible) {
outline: 2px solid var(--pg-primary);
outline-offset: 2px;
z-index: 1;
}

.dz-previews :global(.remove-button *) {
cursor: pointer;
}
Expand Down
5 changes: 5 additions & 0 deletions src/lib/components/filesharing/inputs/UploadedFileTemplate.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@
background-color: var(--pg-soft-background);
}

.remove-button:focus-visible {
outline: 2px solid var(--pg-primary);
outline-offset: 2px;
}

.remove-button * {
cursor: pointer;
}
Expand Down
3 changes: 2 additions & 1 deletion src/lib/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,8 @@ h3 {
}

.primary-btn:focus-visible {
outline: none;
outline: 2px solid var(--pg-primary);
outline-offset: 2px;
}

.crypt-btn:hover:not(:disabled):not([disabled]):not(.crypt-btn-disabled) {
Expand Down