fix: add inert attribute to background content when popup is shown#34
Merged
Conversation
When the validation error popup is displayed, the modal container is moved to document.body via a portal effect so that the inert attribute can safely be applied to <main> and <header>. This prevents keyboard focus from reaching background content while the popup is open.
…run simultaneously
Replace manual inert attribute management + DOM portal approach with a native <dialog> element using showModal(). The browser's top-layer mechanism handles focus trapping and background inertness natively, fixing keyboard navigation leaking to background elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
document.bodyvia a portal$effect, ensuring it sits outside<main>and<header>in the DOMinertattribute to<main>and<header>when the error popup is shown, trapping keyboard focus inside the popupinertattribute from background elements when the popup is closedCloses #22