feat: add styled error pages, fix type errors, add svelte-check CI#65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #42
src/routes/+error.svelte): Card-based layout showing HTTP status code, contextual title/message (404 vs server errors), and a home link. Styled with design tokens, supports dark mode.errorsection to bothen.jsonandnl.jsonwith Dutch and English messages.svelte-check:vite.config.ts: Removed unusedpathimport/__dirname, simplifiedserver.fs.allowto relative'..', cast esbuild polyfill plugins withas anyto fix type mismatchFileInput.svelte: Replaced non-existentDropzone.autoDiscoverwithDropzone.discover = () => []+page.svelte: RenamedErrorimport toErrorPanelto avoid shadowing the built-inErrorconstructordebug/before-send/+page.svelte,debug/done/+page.svelte,debug/upload/+page.svelte: Added missingserverError: falsetoEncryptStateobjectsdownload/+page.svelte: CastselectedLangto'nl' | 'en'to matchYiviCorelanguage option typeDecrypt.svelte: Added@type {any}JSDoc to sessionresult.urldestructured parameter to fixSessionMappingstype mismatchChip.svelte: Changedconst isInteractiveto$derivedto fixstate_referenced_locallywarningEncryptionProgress.svelte: Changedconst toto$derivedto fixstate_referenced_locallywarningsvelte-checkjob to.github/workflows/ci.yml— runs on every push/PR, fails on warnings or errors (Node 24,actions/setup-node@v6).mcp.json) for development toolingTest plan
/nonexistent) and verify the styled 404 page appearsnpx svelte-check --threshold warningpasses with 0 errors and 0 warningsnpm run buildsucceedssvelte-checkjob passes on the PR